Open
Conversation
| $unmark = (int)$_REQUEST['unmark']; | ||
|
|
||
| // Settings | ||
| $page = 50; |
Collaborator
There was a problem hiding this comment.
This might be unrelatedto what you wrote but this variable confuses me. what is page?
sharett
reviewed
Jul 4, 2017
Owner
sharett
left a comment
sharett
left a comment
There was a problem hiding this comment.
Works well for me, but only for the log.php page. Can you also include it anywhere communications.php is included? Could it be part of that file instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks!
So while doing this, it seems communications.php is included from a couple of places where there are missing variables. I want to fix this, but should I do it in a different branch (to keep this one clean?)
Also the changes I made in communications.php might mean it should be using the autorefresh everywhere, which makes more sense anyway.