fix: score CI from the latest run of each check name - #2
Merged
Merged
Conversation
GitHub's statusCheckRollup keeps every check-run on the SHA, so a cancelled workflow's failed gate sits next to the later success and the rollup state stays FAILURE. The PR merge box and `gh pr checks` use the latest run of each name. Match that, and ignore the rollup state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A PR can look red in the pane while GitHub's merge box is green.
statusCheckRollupkeeps every check-run on the SHA. When concurrency cancels an in-progress workflow, its aggregator job still postsFAILURE(if: always()), then the surviving run postsSUCCESS. The rollupstatestaysFAILUREbecause the old run is never deleted.The merge box and
gh pr checksuse the latest run of each check name. The badge now does the same, and no longer consults rollupstate.Behaviour
Verify / gate, later run succeeded✗ci✓ci✗ci(rollup)✗ci1naming the check✗cifrom rollup●ciChecklist
uv run pytest(47 passed) anduv run ruff check .passCHANGELOG.mdhas a line underUnreleased