Upgrade to Mocha V10#48
Closed
alehuo wants to merge 12 commits intoshellscape:masterfrom
alehuo:maintenance/dependency-upgrades
Closed
Upgrade to Mocha V10#48alehuo wants to merge 12 commits intoshellscape:masterfrom alehuo:maintenance/dependency-upgrades
alehuo wants to merge 12 commits intoshellscape:masterfrom
alehuo:maintenance/dependency-upgrades
Conversation
…setup was not called.
Author
|
I will reopen this PR, when I have investigated why CI started failing tests that use mocha-chrome. Locally all seems to be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Mocha v10 has dropped Node.js v12 support. Also, using
mocha-chrometo test projects that do not callmocha.setupwill have to be migrated. I have updated the documentation to reflect this change.This library is now pure ESM. No CommonJS support. If we want to still support CommonJS, we could setup Parcel to bundle both CommonJS and ESM. Maybe add a notification to README.md because of this?
Please Describe Your Changes
v3.0.0v16LTS in the projectThis PR has been tested in a large-scale project which needed updates to its dependencies. Mocha-chrome was one dependency that included a security vulnerability which required Mocha to be updated to v10. I'm happy to assist in further improvements to the library.
Relevant pull requests: #45 #47