Skip to content

feat(daemon): display CCOtel debug config in status command #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Dec 25, 2025
Merged

feat(daemon): display CCOtel debug config in status command #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion commands/daemon.status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ func commandDaemonStatus(c *cli.Context) error {
fmt.Printf(" Socket Path: %s\n", socketPath)

if cfg.CCOtel != nil && cfg.CCOtel.Enabled != nil && *cfg.CCOtel.Enabled {
fmt.Printf(" CCOtel: enabled (port %d)\n", cfg.CCOtel.GRPCPort)
debugStatus := "off"
if cfg.CCOtel.Debug != nil && *cfg.CCOtel.Debug {
debugStatus = "on"
}
Comment on lines +68 to +70

@gemini-code-assist gemini-code-assist Bot Dec 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for checking the nullable boolean cfg.CCOtel.Debug is correct. However, this pattern of checking ptr != nil && *ptr is used multiple times in this file (e.g., for CCOtel.Enabled, CCOtel.Debug, and CodeTracking.Enabled). To improve code clarity and maintainability by reducing repetition, consider abstracting this logic into a helper function.

For example:

// isTrue checks if a *bool is non-nil and true.
func isTrue(b *bool) bool {
    return b != nil && *b
}

This would allow you to simplify these checks to if isTrue(cfg.CCOtel.Debug). Since this pattern is becoming more common in the codebase, introducing a helper function would be a good maintainability improvement.

fmt.Printf(" CCOtel: enabled (port %d, debug %s)\n", cfg.CCOtel.GRPCPort, debugStatus)
} else {
fmt.Println(" CCOtel: disabled")
}
Expand Down