Update the algorithm for validate anagram#2
Open
tlkahn wants to merge 1 commit intoshichao-an:masterfrom
tlkahn:patch-1
Open
Update the algorithm for validate anagram#2tlkahn wants to merge 1 commit intoshichao-an:masterfrom tlkahn:patch-1
tlkahn wants to merge 1 commit intoshichao-an:masterfrom
tlkahn:patch-1
Conversation
Current algorithm does not wok for such cases like print(s.is_anagram("aabb", "abab")), since it only counts the characters but ignores the order.
redfox193
reviewed
Oct 30, 2023
redfox193
left a comment
redfox193
left a comment
There was a problem hiding this comment.
Your function return false on the example test case: s = "anagram", t = "nagaram", but it must return true!
One of the easiest way to solve this task is basicly to sort both string and compsre them. You get O(n logn) complexity and successfuly pass on Leetcode :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current algorithm does not wok for such cases like print(s.is_anagram("aabb", "abab")), since it only counts the characters but ignores the order.