fix: consider time zone during migration of orders#9
Draft
Dennis Garding (DennisGarding) wants to merge 5 commits intotrunkfrom
Draft
fix: consider time zone during migration of orders#9Dennis Garding (DennisGarding) wants to merge 5 commits intotrunkfrom
Dennis Garding (DennisGarding) wants to merge 5 commits intotrunkfrom
Conversation
Dennis Garding (DennisGarding)
requested review from
Simon Fiebranz (CR0YD),
Malte Janz (MalteJanz),
Susanne Hartung (ennasus4sun),
Jozsef Damokos (jozsefdamokos),
Lars Kemper (larskemper) and
Nikolas Evers (vintagesucks)
and removed request for
a team
|
|
||
| foreach ($orders as $key => &$order) { | ||
| $order['_locale'] = $locale; | ||
| if (!empty($timezone)) { |
There was a problem hiding this comment.
we should avoid using empty()
Jozsef Damokos (jozsefdamokos)
requested changes
Apr 27, 2026
| /** | ||
| * @return string|null | ||
| */ | ||
| public function getDatabaseTimezone() |
There was a problem hiding this comment.
I dont think OrderRepository is the correct place for this
Malte Janz (MalteJanz)
requested changes
Apr 28, 2026
Comment on lines
+119
to
+126
| SELECT timeZones.timeZone | ||
| FROM ( | ||
| SELECT @@SESSION.time_zone AS timeZone | ||
| UNION | ||
| SELECT @@system_time_zone AS timeZone | ||
| ) AS timeZones | ||
| WHERE timeZone != 'SYSTEM' | ||
| LIMIT 1 |
Contributor
There was a problem hiding this comment.
See my comments in the assistant PR:
shopware/SwagMigrationAssistant#184 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is necessary to complete the issue: shopware/shopware#14186
See PR: shopware/SwagMigrationAssistant#184