Repository navigation
fix: detect connect-time MCP toolsets through core's public constant - #312
Merged
Dominik Grothaus (dgrothaus-sw) merged 1 commit intoOct 26, 2026
Merged
Conversation
`UcpMcpToolset::coreSupportsConnectTimeToolsets()` now checks for `McpToolsetRegistry::ALL_TOOLSETS`. Core's release notes name that constant for this since 6.7.16.0. It probed the internal `McpRequestedToolsetResolver` class before. The comment on `UcpMcpToolset::QUERY_PARAMETER` now names core's public `McpToolsetRegistry::QUERY_PARAMETER`. That constant exists from 6.7.16.0. `docs/shopware-version-differences.md` has a new section on what the first `tools/list` of `/ucp/mcp` and `/store-api/_mcp` contains on each Shopware line, and which mechanism provides it. It replaces the note that the Store API MCP endpoint is still waiting for shopware/shopware#17228. The rationale now lives in that section. The comments in the code keep only the constraint each one enforces. The docblock of `pinUcpToolset()` no longer says that it runs after the signature check, because OPTIONS requests reach it first. `ShopwareVersionDetector::isAtLeast()` was removed, because only tests called it. `UcpMcpDiscoveryFlowTest` compares the version itself. Follow-up to #261.
Dominik Grothaus (dgrothaus-sw)
requested a review
from Björn Meyer (BrocksiNet)
October 23, 2026 12:23
Björn Meyer (BrocksiNet)
approved these changes
Oct 26, 2026
Dominik Grothaus (dgrothaus-sw)
deleted the
fix-ucp-mcp-toolset-follow-ups
branch
October 26, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension now recognises Shopware's connect-time toolset selection by the public constant that Shopware's release notes name for it. It no longer looks for one of Shopware's internal classes. Which tools an agent sees on
/ucp/mcpstays the same on every Shopware version.The lane differences document now says, per Shopware version, which tools the first tool listing of
/ucp/mcpand/store-api/_mcpcontains and what provides them. It no longer says that the Store API MCP endpoint is still waiting for Shopware. The code comments that explained the same thing in four places now keep only the constraint each one enforces.Follow-up to #261.
# next versionin both changelogs.