Repository navigation
fix: preserve FrankenPHP extension build toolchain - #266
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup added in #261 removes GCC and development headers from the FrankenPHP image, causing downstream
install-php-extensions imagickcalls to fail withgcc: not found.Remove the explicit toolchain purge and preserve the base image's manually installed packages. The existing apt cleanup still removes temporary build dependencies.
Fixes #265.
Validation on PHP 8.4.27, Linux ARM64:
gcc: not foundin the previous image.install-php-extensions imagicksuccessfully and confirmedphp --ri imagickreports the module enabled.git diff --checkpassed.