Skip to content

docs: describe what the volatile-lru eviction policy actually evicts - #2606

Merged
Su (sushmangupta) merged 4 commits into
mainfrom
fix/docs-redis-volatile-lru-eviction-wording
Oct 14, 2026
Merged

Su (sushmangupta) merged 4 commits into
mainfrom
fix/docs-redis-volatile-lru-eviction-wording

Conversation

@d-kirkland

@d-kirkland Daniel Kirkland (d-kirkland) commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Five Redis/Valkey pages describe the volatile-lru eviction policy as one that "only automatically deletes data that is expired" (or "carts that are expired"). That is not what the policy does: per the Redis documentation, volatile-lru evicts the least recently used keys that have an expiration (TTL) set, when the memory limit is reached. Such keys do not have to be expired.
  • The docs contradict themselves: redis.md L34 and caches.md L164 already say it correctly ("keeps evicting least recently used keys that have a TTL set", "it will only evict keys that have a TTL").
  • Rewrites the six sentences to say what the policy does (evicts keys that have a TTL, least recently used first, when the memory limit is reached). redis.md L53 ("a key eviction policy that will not delete data that is not expired") now says it never evicts keys without a TTL and can still evict least recently used keys that have one.

Related links

Docs (at origin/main 70b7d45), changed lines:

Docs lines that state it correctly (not changed): redis.md L34, caches.md L164.

Redis documentation (the semantics come from here, not from the platform source): https://redis.io/docs/latest/develop/reference/eviction/ : "volatile-lru: Evict the least recently used keys that have an associated expiration (TTL)."; and the volatile-xxx policies behave like noeviction if no keys have an expiration.

Platform context (tag v6.7.15.1): carts are stored with a TTL (RedisCartPersister.php L118: $options = [self::EXPIRES_IN_SECONDS => $this->expireDays * 86400];), which is why volatile-lru can evict them in cart-storage.md. Also: compose.yaml L67 runs the cache service with --maxmemory-policy volatile-lfu. This is context only; this PR does not change which policy is recommended.

Checklist

  • I reviewed affected links, code samples, and cross-references, including PageRef references where relevant. (Every changed sentence was compared with the Redis documentation; the pages' own correct statements were left alone.)
  • I added or updated redirects in .gitbook.yaml if pages were moved, renamed, or deleted. (N/A, no page moved.)
  • I updated .wordlist.txt (and sorted it) if spellcheck flags new legitimate terms. (No new prose words outside code spans; checked against .wordlist.txt; the docker spellcheck image could not be run locally.)
  • Any required dependent changes in downstream modules have already been merged and published. (N/A)
  • This pull request is ready for review.

Notes

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@d-kirkland Daniel Kirkland (d-kirkland) added Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document labels Oct 13, 2026
@shopware-dev-docs-connector

shopware-dev-docs-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Completed with success.
Repository: shopware/docs
Commit: 4593b6d
Preview: https://developer-documentation-etvj3he6q-shopware-frontends.vercel.app
Workflow run: #5632

@shopware-dev-docs-connector

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Running.
Repository: shopware/docs
Commit: 4191f44
Preview: Waiting for workflow logs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sushmangupta
Su (sushmangupta) merged commit ac6fde7 into main Oct 14, 2026
8 checks passed
@sushmangupta
Su (sushmangupta) deleted the fix/docs-redis-volatile-lru-eviction-wording branch October 14, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants