refactor(project): move creation logic into shop package#1227
Merged
Conversation
Member
Author
|
Copilot resolve the merge conflicts in this pull request |
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
+ Coverage 52.70% 52.96% +0.25%
==========================================
Files 298 300 +2
Lines 23068 23108 +40
==========================================
+ Hits 12158 12238 +80
+ Misses 10910 10870 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tomasz Turkowski (tturkowski)
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShopwareProjectScaffoldininternal/shopfor composer, filesystem, deployment, and CI scaffoldingcmd/projectWhy
Reusable project-creation behavior lived in the CLI package, which made it difficult to exercise independently and allowed non-CLI callers to bypass validation. Keeping the project contract in
internal/shopmakes the behavior directly testable and ensures the scaffold validates its target before writing files.Impact
Direct scaffold callers now receive the same validation and normalization as the CLI. In particular, unsupported deployment or CI values are rejected, non-empty project directories are protected from overwrite, and Shopware PaaS consistently enables Elasticsearch.
Validation
go test ./...