SG-44731 Adopt Git LFS for tk-framework-desktopserver vendored dependency ZIPs - #365
Open
julien-lang wants to merge 8 commits into
Open
SG-44731 Adopt Git LFS for tk-framework-desktopserver vendored dependency ZIPs#365julien-lang wants to merge 8 commits into
julien-lang wants to merge 8 commits into
Conversation
- .gitattributes: track resources/**/*.zip via Git LFS - .tkdeploy: refresh packaging exclusions to match files actually used today (drop .travis.yml/appveyor.yml, add .pre-commit-config.yaml, azure-pipelines, resources/python/pipelines, and the various resources/python/* build/script extensions) - azure-pipelines.yml: temporarily pin the tk-ci-tools template ref to ticket/SG-44731-use-git-lfs for end-to-end testing before that PR merges - resources/python/src/*/pkgs.zip: re-added as LFS pointers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 65.82% 65.82%
=======================================
Files 24 24
Lines 1870 1870
=======================================
Hits 1231 1231
Misses 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
julien-lang
marked this pull request as ready for review
September 8, 2026 22:31
This reverts commit 8dc894f.
stevelittlefish
approved these changes
Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
LFS payload migration and documented LFS-aware runtime setup remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adopts Git LFS for vendored dependency archives and native binaries to reduce repository and clone size.
Changes:
- Adds LFS attributes for
.zip,.so, and.pydfiles underresources/. - Requires corresponding payload migration and LFS-aware checkout documentation.
File summaries
| File | Summary |
|---|---|
.gitattributes |
Adds Git LFS handling for vendored binary resources; migration and runtime setup updates remain unresolved. |
Review details
Suppressed comments (1)
.gitattributes:3
- These patterns only change attribute resolution; they do not convert the already-tracked ZIPs (or the newly matched
.so/.pydfiles) into Git LFS pointer blobs. Because this PR contains no corresponding binary/index updates, the repository will continue storing the existing payloads in normal Git and the clone-size reduction will not occur. Re-add/migrate every matched file with Git LFS and commit the resulting pointer changes alongside these attributes.
resources/**/*.zip filter=lfs diff=lfs merge=lfs -text
resources/**/*.so filter=lfs diff=lfs merge=lfs -text
resources/**/*.pyd filter=lfs diff=lfs merge=lfs -text
- Files reviewed: 1/41 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+3
| resources/**/*.zip filter=lfs diff=lfs merge=lfs -text | ||
| resources/**/*.so filter=lfs diff=lfs merge=lfs -text | ||
| resources/**/*.pyd filter=lfs diff=lfs merge=lfs -text |
Comment on lines
+2
to
+3
| resources/**/*.so filter=lfs diff=lfs merge=lfs -text | ||
| resources/**/*.pyd filter=lfs diff=lfs merge=lfs -text |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SG-44731 adopts Git LFS for vendored dependency ZIPs to reduce Toolkit repo/clone size. Replaces #338, which was an earlier proof of concept under a prior ticket number.
Changes
resources/**/*.zip(pkgs.zipfor all supported Python versions) are now tracked via Git LFS (filter=lfs diff=lfs merge=lfs -textin.gitattributes).Related PRs
checkout: self, lfs: truestep this repo's pipeline needs.tk-core's vendored dependency ZIPs.