Open
Conversation
Before this edit, on lines 49 and 62, you were using `createText` to insert a whitespace before and after certain elements. This would add the whitespace so the sentence didn't have any missing whitespaces, but those new whitespaces weren't being added to the allElements array. This makes those newly create whitespaces to be un-splittable. By taking line 54 and replacing lines 46. and 62. you add these whitespaces to the allElements array, allowing them to be split correctly.
|
@Gbillington1 you should add test(s) Also, is this at all related to #76 ? |
Author
Yeah I probably should've but this was 5 years ago, I was 16 years old and didn't know any better. And its not related to that issue to my knowledge, I was working on extracting lines of text from web pages, and this white space issue was causing some line breaks to go undetected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this edit, on lines 49 and 62, you were using
createTextto insert a whitespace before and after certain elements. This would add the whitespace so the sentence didn't have any missing whitespaces, but those new whitespaces weren't being added to the allElements array. This makes those newly create whitespaces to be un-splittable. By taking line 54 and replacing lines 46. and 62. you add these whitespaces to the allElements array, allowing them to be split correctly.