refactor(electron-titlebar): use relative units for electron-titlebar#1870
refactor(electron-titlebar): use relative units for electron-titlebar#1870
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the $si-titlebar-height variable from pixels to rem units. While the conversion is accurate, it introduces a unit inconsistency with adjacent layout variables like $si-application-header-height and $si-system-banner-height. It is recommended to convert all related layout dimensions in this block to relative units to ensure consistent scaling across the application.
| $si-application-header-height: 48px; | ||
|
|
||
| $si-titlebar-height: 36px; | ||
| $si-titlebar-height: 2.25rem; |
There was a problem hiding this comment.
The conversion of $si-titlebar-height to rem units is correct (36px / 16px = 2.25rem). However, this change introduces an inconsistency with the adjacent layout variables $si-application-header-height (48px) and $si-system-banner-height (20px) which are still using absolute pixel units. For consistent scaling across the application layout when the root font size changes, it is recommended to convert all related layout dimensions in this block to relative units.
1 participant
See https://code.siemens.com/simpl/simpl-element/-/work_items/4
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: