Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the calculation of total pages in the pagination component by replacing the nullish coalescing operator with a logical OR operator for the page size. This change ensures that a page size of zero defaults to one, preventing potential division by zero errors. I have no feedback to provide.
akashsonune
force-pushed
the
fix/handle-page-size-sero
branch
from
53499ad to
e9323ad
Compare
Member
|
Seems like we lack test coverage for the pagination component. Can we either add more test coverage here or otherwise create an issue so we are aware and have it on the backlog. The component has many edge cases, which are not covered by tests. For example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inconsistent state when pagesize is zero
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: