refactor(theme): use relative units for icon badge sizing#1878
refactor(theme): use relative units for icon badge sizing#1878
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates badge styles by converting pixel-based dimensions and offsets to rem units and changing a border-radius to a percentage. The feedback recommends using the typography.px-to-rem() utility function instead of hardcoded rem values to improve maintainability and ensure consistency with the project's styling patterns.
|
Can we fix the navbar and tabs before we merge this PR? Since it difficult to test the behaviour when we increase the font size |
can you be more specific? We already have normal badges that are based on font-size. This is a small independent fix. There's no point in addressing anything else before this |
2 participants
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: