feat(element-theme): align ghost button naming convention#1882
Draft
feat(element-theme): align ghost button naming convention#1882
Conversation
ljanner
added
the
breaking-changes
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors button class naming across the library and examples to align with a new convention where .btn-primary-ghost is renamed to .btn-ghost and the previous .btn-ghost is updated to .btn-tertiary-ghost. Feedback identifies an accessibility issue in the si-input-pill component where a span is used for an interactive deletion action; it is recommended to use a proper button element with an aria-label and stop event propagation to ensure keyboard focus and prevent event bubbling.
ljanner
force-pushed
the
refactor/ghost-button-naming
branch
2 times, most recently
from
fddf6cc to
49e47ef
Compare
`.btn-ghost` now represents the primary ghost button style, consistent with the naming convention established by `.btn-secondary-ghost` and `.btn-tertiary-ghost`. All internal usages of the old `.btn-ghost` (which had tertiary ghost styling) have been migrated to `.btn-tertiary-ghost`. The transitional `.btn-primary-ghost` class introduced in v49.5.0 has been removed. Resolves #1797 BREAKING CHANGE: `.btn-ghost` no longer applies tertiary ghost styling. When using `.btn-ghost` as a tertiary ghost button it must be renamed to `.btn-tertiary-ghost`. A schematic migration will be provided to automate this update.
ljanner
force-pushed
the
refactor/ghost-button-naming
branch
from
49e47ef to
bb454ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.btn-ghostnow represents the primary ghost button style, consistent with the naming convention established by.btn-secondary-ghostand.btn-tertiary-ghost. All internal usages of the old.btn-ghost(which had tertiary ghost styling) have been migrated to.btn-tertiary-ghost. The transitional.btn-primary-ghostclass introduced in v49.5.0 has been removed.Resolves #1797
BREAKING CHANGE:
.btn-ghostno longer applies tertiary ghost styling. When using.btn-ghostas a tertiary ghost button it must be renamed to.btn-tertiary-ghost. A schematic migration will be provided to automate this update.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: