feat(dashboards-ng): add translation support for widget name, description, and heading#1893
Open
chintankavathia wants to merge 1 commit intomainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces internationalization support for widget metadata by changing the types of name, description, and heading from string to TranslatableString. The widget catalog component has been updated to use the translate pipe in templates and the translateSync method for filtering, alongside the addition of translation keys and unit tests. Feedback highlights the need to remove an unsafe .trim() call on the translatable description property and to shorten translation strings in both English and German to align with UX writing guidelines for conciseness.
…tion, and heading Widget names and descriptions in the catalog now support translation keys, allowing localized widget catalog. The `heading` field in `WidgetConfig` is now typed as `TranslatableString` for consistency with downstream `si-card` components that already apply translation.
chintankavathia
force-pushed
the
feat/dashboards/support/translatable/widget/name-description
branch
from
8b1abee to
bd75f07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widget names and descriptions in the catalog now support translation keys, allowing localized widget catalog.
The
headingfield inWidgetConfigis now typed asTranslatableStringfor consistency with downstreamsi-cardcomponents that already apply translation.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: