fix(dashboards-ng): do not clip focus-ring in footer#1895
Draft
spike-rabbit wants to merge 1 commit intomainfrom
Draft
fix(dashboards-ng): do not clip focus-ring in footer#1895spike-rabbit wants to merge 1 commit intomainfrom
spike-rabbit wants to merge 1 commit intomainfrom
Conversation
The footer / paddings were constructed wrong. In general components in element do not have a build-in padding. Especially not on the block-end. Those are consumer supplied. Exceptions are footer actions and inputs. This rule is violated by the `si-dashboard` which was having a `padding-block-end` leading to the actual footer not having `padding-block-end` and thus causing the focus border to be clipped.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adjusts the layout and spacing of the widget catalog and dashboard components by removing margin and padding classes from top-level containers and updating the footer padding in the widget catalog. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer / paddings were constructed wrong.
In general components in element do not have a build-in padding. Especially not on the block-end.
Those are consumer supplied. Exceptions are footer actions and inputs. This rule is violated by the
si-dashboardwhich was having apadding-block-endleading to the actual footer not havingpadding-block-endand thus causing the focus border to be clipped.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: