Skip to content

Add ability for the opamp client to use the x-sf-token header#2934

Draft
breedx-splk wants to merge 3 commits into
signalfx:mainfrom
breedx-splk:opamp_token
Draft

Add ability for the opamp client to use the x-sf-token header#2934
breedx-splk wants to merge 3 commits into
signalfx:mainfrom
breedx-splk:opamp_token

Conversation

@breedx-splk

Copy link
Copy Markdown
Contributor

If the opamp client is to be used without a collector, then it will need the ability to set the token header.

@robsunday

Copy link
Copy Markdown
Contributor

Are you going to add OpampClientConfigurationFactory and OpampClientConfigurationFactoryTest changes in this PR, or another one will be created?

Comment thread opamp/src/main/java/com/splunk/opentelemetry/opamp/OpampClientConfiguration.java Outdated
@breedx-splk

Copy link
Copy Markdown
Contributor Author

Are you going to add OpampClientConfigurationFactory and OpampClientConfigurationFactoryTest changes in this PR, or another one will be created?

Why, does OpampClientConfigurationFactory require something extra/special? I thought this would already cover those.

@robsunday

Copy link
Copy Markdown
Contributor

OpampClientConfiguration.Builder.withAccessToken() is called in tests to setup confiuration so tests pass, but it is not called from production code when starting the agent.

OpampClientConfiguration is created in two methods:

  • OpampClientConfigurationFactory.createConfigurationFromDeclarativeConfig
  • OpampClientConfigurationFactory.createConfiguration(ConfigProperties) - used for environment config

OpampClientConfiguration.Builder.withAccessToken() should be called there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants