Fix metadata generator crash#2943
Merged
Merged
Conversation
robsunday
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR open-telemetry/opentelemetry-java-instrumentation#19150 added some metadata for configuration items that only exist in declarative config. We expect each config item to have a
namefield so that we can populate it in the docs table or whatever...but now that's inconsistent/broken.I first tried falling back to the declarative name when name is missing, but that will end up fabricating false env vars in the docs, which I thought was bad.
So this seems like a minimally stupid way of preventing the metadata gen from crashing, at least until we can figure out how we think we want to generate docs for declarative config.