Remove obsolete system metrics setting - #785
Merged
Merged
Conversation
pmcollins
marked this pull request as ready for review
August 10, 2026 21:50
JWinermaSplunk
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPLUNK_OTEL_SYSTEM_METRICS_ENABLEDconstantWhy
SPLUNK_OTEL_SYSTEM_METRICS_ENABLEDwas introduced during the 2.x rewrite but was never read by the runtime. System metrics are enabled through auto-instrumentation and can be disabled withOTEL_PYTHON_DISABLED_INSTRUMENTATIONS=system_metrics.The orphaned constant was later treated as a supported setting by the metadata generator, causing generated release metadata to document a toggle that has no effect.
Impact
Generated metadata no longer advertises an unsupported system-metrics configuration variable. Runtime behavior is unchanged.
Validation
hatch run pytest -q tests/test_generate_metadata.py tests/test_env.py(7 passed)hatch run ruff check src/splunk_otel/env.py tools/generate_metadata.py tests/test_generate_metadata.pygit diff --check