TT-7414 Cleanup title editing - TitleEdit doesn't keep copy. Value i…#361
Merged
Conversation
… only sent down if not editing.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines title editing behavior in the renderer by removing redundant local title state and preventing parent-prop updates from overwriting in-progress edits, while also simplifying a sheet update pathway.
Changes:
- Updated
MediaTitleto track focus and only synctitleprop into local input state when not actively editing (or whentitlekeychanges). - Simplified
TitleEditby removing its internal title copy and rendering directly from thetitleprop. - Refactored
ScriptureTablecell updates to apply immediately when not saving/updating, and defer only when blocked.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/renderer/src/control/MediaTitle.tsx | Adds focus-aware syncing between title prop and local input value; introduces a ref-backed current text for blur handling. |
| src/renderer/src/components/Sheet/TitleEdit.tsx | Removes local title state so MediaTitle is the single source of editing behavior. |
| src/renderer/src/components/Sheet/ScriptureTable.tsx | Extracts applyCellChanges and avoids unconditional waiting when applying edits. |
gtryus
requested changes
Jun 16, 2026
gtryus
left a comment
gtryus
left a comment
Contributor
There was a problem hiding this comment.
I proposed a small improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s only sent down if not editing.