Add DaisyUI debug theme for dev server#1075
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA non-default DaisyUI debug theme sets design tokens to red. The main layout selects this theme in development mode, logs a warning, and leaves the theme unset otherwise. ChangesDevelopment debug theme
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Use: Instead of using |
eb4c4f8 to
b7df389
Compare
b7df389 to
1ac1e7b
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/styles/app.css`:
- Around line 18-37: Update every --color-* custom property in the theme token
block to use the raw red color value without quotes, preserving the existing
token names and values.
In `@src/routes/`+layout.svelte:
- Around line 144-149: Update the non-dev branch of the data-theme expression in
the layout markup to return the existing light theme name instead of default,
while preserving the dev branch’s debug theme behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a9e189d-efbd-44d3-a8be-4cc43557da47
📒 Files selected for processing (2)
src/lib/styles/app.csssrc/routes/+layout.svelte
|
This would be a bit cleaner: |
chrisvire
left a comment
There was a problem hiding this comment.
Good job! I hope this will help us find areas were we are not correctly theming the app.

Related to #1037 and the corresponding PR at #1047. Missing SAB colors that fall through to DaisyUI defaults should now show as red during development to increase visibility. This occurs only when the
devserver is running since that's when SvelteKit'sdevvar istrue.Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes