Extract mountActiveSegment/mountSnapSpacer test helpers#106
Conversation
Replace the 11 inline aria-current="true" recenter-target setups in useSegmentWindow.test.ts with two composable local helpers, mirroring the existing mountSegmentEls. Two helpers (rather than one spacer-option helper) keep both return types a plain HTMLElement, avoiding an HTMLElement | undefined union at the call sites that the no-type-assertion rule would make awkward. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo DOM setup helpers, ChangesTest DOM Setup Helper Extraction
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
@alex-rawlings-yyc reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
Replace the 11 inline aria-current="true" recenter-target setups in useSegmentWindow.test.ts with two composable local helpers, mirroring the existing mountSegmentEls. Two helpers (rather than one spacer-option helper) keep both return types a plain HTMLElement, avoiding an HTMLElement | undefined union at the call sites that the no-type-assertion rule would make awkward.
Devin: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/106
This change is
Summary by CodeRabbit