Tiny tweaks#109
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- MorphemeEditor: normalize internal whitespace in isUnedited to avoid no-op saves on spacing-only changes - TokenChip: document the deliberate onOpenChange omission on the controlled Popover Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
imnasnainaec
force-pushed
the
token-analysis-review-fixes
branch
from
ccdfa81 to
5741193
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alex-rawlings-yyc
approved these changes
Jun 17, 2026
alex-rawlings-yyc
left a comment
alex-rawlings-yyc
left a comment
Contributor
There was a problem hiding this comment.
@alex-rawlings-yyc reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
This was referenced Jun 17, 2026
alex-rawlings-yyc
added a commit
that referenced
this pull request
Jun 17, 2026
* Add UI for morphosyntactic analysis of tokens * Improve editor, allow deletion of MSA * Minor adjustments * Add writing system to morpheme pipeline, fix input focus issue, prevent morpheme ID regeneration on unedited done/enter * Minor adjustments * Migrate MorphemeEditor to Platform.Bible popover, clean up analysisSlice, other minor improvements * Recenter on showMorphology toggle * Minor adjustments * Cleanup * Minor adjustments * Memoize viewOptions, clear blank morpheme gloss * Tiny tweaks (#109) * Address token-analysis review comments - MorphemeEditor: normalize internal whitespace in isUnedited to avoid no-op saves on spacing-only changes - TokenChip: document the deliberate onOpenChange omission on the controlled Popover Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add JSDoc to normalize helper in MorphemeEditor Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add validator for show morphology setting * Close morphology popover when token chip disabled, * Morpheme analysis UI: suggestions for #104 (#111) * Address review feedback on morpheme analysis UI - Don't save empty or whole-word morpheme breakdowns: disable the Done button and guard the Enter / outside-click commit paths - Localize morpheme editor strings and morpheme/trigger aria-labels - Validate morpheme element shape in isTextAnalysis at the persistence boundary (isTokenAnalysisRecord / isMorphemeAnalysis) - Restore focus to the token gloss input when the morpheme popover closes - Gate the disabled morpheme trigger's hover/cursor affordance - De-duplicate the boolean project-setting validators into one isBoolean - Document the deliberate provenance exclusion in isEmptyTokenAnalysis and de-stale the viewOptions memo comment Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Focus on 1st morph gloss * Tweak * Extract handle --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fix formatting issue --------- Co-authored-by: D. Ror. <imnasnainaec@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested tweaks on #104
Devin: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/109
This change is
Summary by CodeRabbit
Bug Fixes