Strip duplicate and stale Not-found notes in ExtractXliff#144
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
imnasnainaec
force-pushed
the
fix/113-not-found-notes
branch
from
809a5b3 to
eb35b99
Compare
On master the copy-old-notes loop prepends "[OLD NOTE] " to any note
not already prefixed, so the "Not found" note from a prior merge
survives as "[OLD NOTE] Not found...". StartsWith("Not found") missed
it; Contains("Not found") catches it regardless of prefix.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andrew-polk
approved these changes
Jun 15, 2026
andrew-polk
left a comment
andrew-polk
left a comment
Contributor
There was a problem hiding this comment.
@andrew-polk reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Each run of
ExtractXliff.exe --base-xliffappended a fresh "Not found in static scan..." note without removing the previous one, causing notes to accumulate indefinitely.This change is
Devin review: https://app.devin.ai/review/sillsdev/l10nsharp/pull/144