Add tests for language-tag matching: exact generic beats specifics#147
Open
imnasnainaec wants to merge 2 commits into
Open
Add tests for language-tag matching: exact generic beats specifics#147imnasnainaec wants to merge 2 commits into
imnasnainaec wants to merge 2 commits into
Conversation
…fics) PR #110 fixed the language-tag matching logic but left one rule untested: when an exact generic tag (zh) is available alongside specific variants (zh-CN, zh-TW), the exact match should be used without prompting. Adds TestMappingLanguageCodesToAvailable_ExactGenericMatchUsedWhenSpecificsAlsoExist to both LocalizationManagerTestsBase and XliffLocalizationManagerTests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
imnasnainaec
force-pushed
the
fix/109-tests
branch
from
47b3454 to
5422adb
Compare
imnasnainaec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
PR #110 fixed the language-tag matching logic in
XliffLocalizedStringCache.LoadXliffAndUpdateExistingLanguageMapbut left one rule untested: when an exact generic tag (e.g.zh) is available alongside specific variants (zh-CN,zh-TW), the exact match should be used without prompting the user.Adds
TestMappingLanguageCodesToAvailable_ExactGenericMatchUsedWhenSpecificsAlsoExistto both:src/L10NSharp.Tests/LocalizationManagerTestsBase.cssrc/L10NSharp.Windows.Forms.Tests/XliffLocalizationManagerTests.csEach test sets up all three variants, initialises with
"zh", and asserts: no prompt fires,UILanguageId == "zh", andGetStringreturns the generic-zhtranslation (not CN or TW).Devin review: https://app.devin.ai/review/sillsdev/l10nsharp/pull/147
This change is