Skip to content

Fix NRE in XLiffBody.AddTransUnit when tu.Source is null #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
imnasnainaec wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix NRE in XLiffBody.AddTransUnit when tu.Source is null #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
558172f
Fix NRE in XLiffBody.AddTransUnit when tu.Source is null (#149)
imnasnainaec Jun 8, 2026
227cfd0
Add test and changelog for NRE fix in XLiffBody.AddTransUnit (#149)
imnasnainaec Jun 8, 2026
1f9ff82
Simplify AddTransUnit_NullSourceNullTarget_DoesNotThrow test
imnasnainaec Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- [L10NSharp.Windows.Forms] Restored project-local Resources support for `FallbackLanguagesDlgBase` button images (`Move`, `Move_up`, and `Move_down`).
- [L10NSharp.Windows.Forms] Corrected resource manager base name to `L10NSharp.Windows.Forms.Properties.Resources`.
- [L10NSharp.Windows.Forms.Tests] Corrected resource manager base name to `L10NSharp.Windows.Forms.Tests.Properties.Resources`.
- [L10NSharp] Fixed `NullReferenceException` in `XLiffBody.AddTransUnit` when a trans-unit has no source variant (e.g. from a malformed XLIFF file). (#149)

### Removed

Expand Down
8 changes: 8 additions & 0 deletions src/L10NSharp.Tests/XLiffLocalizationManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,14 @@ public void MergeXliffDocuments_WorksAsExpected()
}, true);
}

[Test]
public void AddTransUnit_NullSourceNullTarget_DoesNotThrow()
{
var body = new XLiffBody();
var tu = new XLiffTransUnit { Id = "some-id", Source = null, Target = null };
Assert.DoesNotThrow(() => body.AddTransUnit(tu));
}

private void CheckMergedTransUnit(XLiffTransUnit tu, string sourceText, string[] notes, bool isDynamic)
{
Assert.IsNotNull(tu);
Expand Down
4 changes: 2 additions & 2 deletions src/L10NSharp/XLiffUtils/XLiffBody.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public bool AddTransUnit(XLiffTransUnit tu)
// the source value there.
if (tu.Target != null && tu.Target.Value != null)
TranslationsById[tu.Id] = tu.Target.Value;
else
else if (tu.Source != null)
TranslationsById[tu.Id] = tu.Source.Value;
return true;
}
Expand Down Expand Up @@ -246,7 +246,7 @@ internal int NumberTranslated
{
++_translatedCount;
}
else if (tu.Target.Value != tu.Source.Value &&
else if (tu.Source != null && tu.Target.Value != tu.Source.Value &&
tu.Target.TargetState == XLiffTransUnitVariant.TranslationState.Undefined)
{
++_translatedCount;
Expand Down
Loading