Fix TOCTOU race condition in XLiffBody.AddTransUnitRaw#154
Merged
Conversation
…pinLock (#150) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andrew-polk
approved these changes
Jun 15, 2026
andrew-polk
left a comment
andrew-polk
left a comment
Contributor
There was a problem hiding this comment.
@andrew-polk reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_transUnitDictwrite inside theSpinLocktry block, closing the TOCTOU window where two threads with the same ID could both pass the check and silently overwrite each other's entry_transUnitIdLockinstance-level (removesstatic) so concurrent operations on differentXLiffBodyinstances no longer contend on a shared lockInterlocked.Incrementwith++inside the SpinLock critical section, where the lock already provides mutual exclusionRemoveTransUnitwhy_transUnitIdLockis intentionally not acquired thereCloses #150
Devin review: https://app.devin.ai/review/sillsdev/l10nsharp/pull/154
This change is