Skip to content

Fix file stream resource leak in CreateOrUpdateDefaultXliffFileIfNecessary#155

Merged
imnasnainaec merged 4 commits into
masterfrom
fix/151-resource-leak
Jun 17, 2026
Merged

Fix file stream resource leak in CreateOrUpdateDefaultXliffFileIfNecessary#155
imnasnainaec merged 4 commits into
masterfrom
fix/151-resource-leak

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #151

Devin review: https://app.devin.ai/review/sillsdev/l10nsharp/pull/155


This change is Reviewable

…ssary (#151)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Test Results

    7 files  ±0  104 suites  ±0   22s ⏱️ -1s
170 tests ±0  165 ✔️ ±0    5 💤 ±0  0 ±0 
646 runs  ±0  631 ✔️ ±0  15 💤 ±0  0 ±0 

Results for commit 3125d82. ± Comparison against base commit d8b165c.

♻️ This comment has been updated with latest results.

@imnasnainaec imnasnainaec self-assigned this Jun 8, 2026
@imnasnainaec imnasnainaec marked this pull request as draft June 8, 2026 17:29
@imnasnainaec imnasnainaec marked this pull request as ready for review June 8, 2026 17:44
Comment thread src/L10NSharp.Tests/LocalizationManagerTestsBase.cs Outdated
Comment thread src/L10NSharp.Tests/LocalizationManagerTestsBase.cs Outdated

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 3 files and all commit messages, resolved 1 discussion, and dismissed @hahn-kev from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec dismissed tombogle’s stale review June 17, 2026 16:26

Suggestion incorporated and reviewed by another person.

@imnasnainaec imnasnainaec merged commit ed7edeb into master Jun 17, 2026
6 checks passed
@imnasnainaec imnasnainaec deleted the fix/151-resource-leak branch June 17, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File stream resource leak in CreateOrUpdateDefaultXliffFileIfNecessary

3 participants