Add activity filters to the activity view#2357
Conversation
- Updated ProjectActivity method to accept additional parameters for filtering by author and sorting. - Introduced ListActivityAuthors and ListActivityChangeTypes methods to retrieve distinct authors and change types. - Added ActivityQuery record to encapsulate query parameters. - Implemented frontend components for filtering activities by author and change type. - Updated TypeGen configuration to include new types for activity authors and change types. - Added tests for new functionality in HistoryService. This commit improves the activity tracking capabilities and enhances the user experience by allowing more granular filtering of activities.
github-actions
Bot
added
the
💻 FW Lite
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughExtends the project activity feed with author filtering, change-type filtering, FieldWorks exclusion, and sort ordering. New ChangesActivity Filter, Sort, and Author/Change-Type Listing
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
C# FwHeadless Unit Tests48 tests 48 ✅ 16s ⏱️ Results for commit 6c60a50. ♻️ This comment has been updated with latest results. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
C# Unit Tests165 tests 165 ✅ 21s ⏱️ Results for commit 6c60a50. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
backend/FwLite/LcmCrdt.Tests/HistoryServiceActivityTests.cs (1)
91-104: ⚡ Quick winAdd a synced-order regression test with two synced commits using different offsets.
Current synced coverage checks synced-vs-unsynced placement, but not relative ordering between synced commits whose
SyncDateoffsets differ. Add that case to prevent regressions in synced sort semantics.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/FwLite/LcmCrdt.Tests/HistoryServiceActivityTests.cs` around lines 91 - 104, The test method ProjectActivity_SyncedSort_PlacesUnsyncedLast currently only verifies relative ordering between a synced and an unsynced commit, but does not test the relative ordering between multiple synced commits with different SyncDate offsets. Add a second synced commit with a different DateTimeOffset value (either earlier or later than the first synced commit's date), then use Array.FindIndex to locate both synced commits in the results and add an assertion to verify they are ordered correctly relative to each other according to the ActivitySort.SyncedNewestFirst sort semantics.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/viewer/src/lib/activity/ActivityView.svelte`:
- Around line 130-131: The style attribute in the div element contains an
invalid CSS declaration with orphaned minmax fragments on line 131. The fragment
"minmax(min-content, 1fr) minmax(min-content, 2fr);" appears between
grid-template-rows and grid-template-columns without a property name, causing
the browser to ignore it. Remove this orphaned fragment from the style attribute
to ensure the grid layout declaration is valid and the layout behavior is
consistent.
---
Nitpick comments:
In `@backend/FwLite/LcmCrdt.Tests/HistoryServiceActivityTests.cs`:
- Around line 91-104: The test method
ProjectActivity_SyncedSort_PlacesUnsyncedLast currently only verifies relative
ordering between a synced and an unsynced commit, but does not test the relative
ordering between multiple synced commits with different SyncDate offsets. Add a
second synced commit with a different DateTimeOffset value (either earlier or
later than the first synced commit's date), then use Array.FindIndex to locate
both synced commits in the results and add an assertion to verify they are
ordered correctly relative to each other according to the
ActivitySort.SyncedNewestFirst sort semantics.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5bd4e79f-5dfb-45f0-9803-e9062c28582b
📒 Files selected for processing (26)
backend/FwLite/FwLiteShared/Services/HistoryServiceJsInvokable.csbackend/FwLite/FwLiteShared/TypeGen/ReinforcedFwLiteTypingConfig.csbackend/FwLite/FwLiteWeb/Routes/ActivityRoutes.csbackend/FwLite/LcmCrdt.Tests/HistoryServiceActivityTests.csbackend/FwLite/LcmCrdt/HistoryService.csfrontend/viewer/src/lib/activity/ActivityFilter.sveltefrontend/viewer/src/lib/activity/ActivityView.sveltefrontend/viewer/src/lib/activity/utils.tsfrontend/viewer/src/lib/dotnet-types/generated-types/FwLiteShared/Services/IHistoryServiceJsInvokable.tsfrontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/ActivitySort.tsfrontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/IActivityAuthor.tsfrontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/IActivityChangeType.tsfrontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/IActivityQuery.tsfrontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/IProjectActivity.tsfrontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/index.tsfrontend/viewer/src/lib/history/HistoryView.sveltefrontend/viewer/src/lib/services/history-service.tsfrontend/viewer/src/lib/services/service-provider-dotnet.tsfrontend/viewer/src/locales/en.pofrontend/viewer/src/locales/es.pofrontend/viewer/src/locales/fr.pofrontend/viewer/src/locales/id.pofrontend/viewer/src/locales/ko.pofrontend/viewer/src/locales/ms.pofrontend/viewer/src/locales/sw.pofrontend/viewer/src/locales/vi.po
|
This is very cool. I find several things about the UI a little awkward: 1) I think it would be great if we combined the author options (dropdown and FieldWorks switch)E.g. something like this:
I assume grouping them is more intuitive.
2) The sort options are cool, but challenging. They have non-trivial meanings.
3) The whole view width?I'm a bit surprised you opted for a design that uses the whole width of the view, rather than just the changes panel e.g. how the filters in the browse view are only above the entry list. |
|
In the meeting we decided
|
2 participants
Users of the activity page can now filter by Author, Change Type, and order by sync date.
Author filter:
Change type filter:
