Media manager#2358
Conversation
- Introduced MediaFileDetail component for displaying file details and handling file downloads. - Implemented GetFileStream method in MediaFilesServiceJsInvokable to retrieve file streams. - Updated ILcmFileMetadata to include SizeInBytes property. - Enhanced IMediaFilesServiceJsInvokable interface with getFileStream method.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
💻 FW Lite
C# FwHeadless Unit Tests48 tests 48 ✅ 18s ⏱️ Results for commit e19ea6f. ♻️ This comment has been updated with latest results. |
C# Unit Tests165 tests 165 ✅ 20s ⏱️ Results for commit e19ea6f. ♻️ This comment has been updated with latest results. |
|
You're fast ;). It's a little funny how much the right panel looks like an email 😄 I'm wondering how users will find things? Or maybe they don't actually want to? What are the real use cases for this?
If that's all, then, this is probably fine. Maybe we just need a filter for "Unused media" i.e. orphaned stuff. Nit: can we make the resource "names" align vertically e.g. by either stacking the cloud and local icons vertically instead of horizontally or putting them in the second row? Maybe like the part of speech badge 🤔 or maybe put the icons into the "Local and remote" text? I'm guessing the "Download all" is actually for making stuff available offline, rather than saving a copy of everything somewhere on your device right? "Downloading" sounds like "Saving" to me. "Make all media available offline" is a bit long for a button text 😆. Maybe we just change it to "Download all..." (i.e. with 3-dots), so users know it opens a dialog and the dialog then has an explanation and submit button? The GDocs UI for making things available offline is a bit weird. I first clicked a button in this overlay to make my doc "ready for offline use": After that I was able to open, edit and comment on the document while offline. When I click it, it changes to: I see no differences in behaviour after enabling that second option. |
|
Another use case I could see is removing files locally (to free up space), not sure how realistic that is though. On android there's a distinction between cache and data, we should probably figure that out to download stuff into cache. Yes you noticed another terminology issue we stumbled in to. I think download in this context could mean either, export so I can use it for whatever, or download to my device from the server. So we should probably just not use the word download. What if we just used the term "Load" and "Load all" for the current "Download all" button which loads for offline use. We currently use "Save As" for getting files out of the app, I think that can stay as is. 
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…d code to pull in metadata
…just icons so they dont shift the layout
github-actions
Bot
added
the
📦 Lexbox
2 participants
Lets users view media associated with the project. Manually trigger downloading all media or upload pending.
This has highlighted an issue with our current strategy/design. Right now the metadata for media files only lives on lexbox, if the file isn't downloaded we don't even know the file name or type. It would be really nice to store the metadata with the resource, so that gets synced between clients automatically. This may require a harmony change, but there could be other ways to do this.