Open
Conversation
removed wmic, replaced with powershell calls.
bumping version number
There was a problem hiding this comment.
Pull Request Overview
This PR updates Windows support by removing the legacy WMIC-based process fetching and replacing it with PowerShell calls. Key changes include:
- Removal of WMIC-related tests and code.
- Addition of tests and implementation for fetching processes using PowerShell.
- Update of the platform mapping in lib/get.js to use the new PowerShell approach.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/wmic.js | Removed tests for WMIC in favor of PowerShell implementation. |
| test/powershell.js | Added new tests to validate PowerShell output and error handling. |
| lib/wmic.js | Removed WMIC module as it is no longer used. |
| lib/powershell.js | Introduced new module for process fetching using PowerShell. |
| lib/get.js | Updated platform mapping to use PowerShell instead of WMIC for win. |
Files not reviewed (1)
- package.json: Language not supported
|
@simonepri what do you think abot this? Have this project worked without wmic would be great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed wmic, replaced with powershell calls.