Skip to content

Drop aws - #1

Merged
simonmcmanus merged 24 commits into
mainfrom
drop-aws
Jan 3, 2026
Merged

Drop aws#1
simonmcmanus merged 24 commits into
mainfrom
drop-aws

Conversation

@simonmcmanus

Copy link
Copy Markdown
Owner

No description provided.

@netlify

netlify Bot commented Nov 16, 2025

Copy link
Copy Markdown

Deploy Preview for simonmcmanus ready!

Name Link
🔨 Latest commit a2b4556
🔍 Latest deploy log https://app.netlify.com/projects/simonmcmanus/deploys/69590e6cf498680008951ae8
😎 Deploy Preview https://deploy-preview-1--simonmcmanus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@simonmcmanus
simonmcmanus requested a review from Copilot January 3, 2026 12:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates storage from AWS S3 to Netlify Blobs, updates the codebase to ES modules (import/export), and removes Twitter integration.

Key Changes:

  • Replaces AWS S3 storage with Netlify Blobs API using separate stores for JSON and images
  • Converts all function files from CommonJS (require/exports) to ES modules (import/export)
  • Updates response format from legacy Netlify function format to new Response API
  • Removes Twitter integration (tweet.js deleted)

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
package.json Adds Netlify packages, retains aws-sdk dependency despite migration
netlify-json/fetch.sh Adds shell script for fetching JSON from Netlify blobs (has line break issue)
__functions/url-summary.js Converts to ES modules, updates response format, adds error handling for URL fetching
__functions/upload-image.js Converts to ES modules, removes inline upload function (now imported from storage)
__functions/tweet.js Removes Twitter integration entirely
__functions/tags.js Converts to ES modules, updates response format
__functions/storage.js Replaces AWS S3 implementation with Netlify Blobs API
__functions/netlify.js Converts to ES modules, adds response return value
__functions/list-notes.js Converts to ES modules, updates response format
__functions/list-links.js Converts to ES modules, updates response format
__functions/deploy-succeeded.js Converts to ES modules, adds response return value
__functions/cv-ai.js Converts to ES modules, updates response format
__functions/build.js Converts to ES modules, adds response return value
__functions/bluesky.js Converts to ES modules, adds response return value
__functions/add-link.js Converts to ES modules, updates response format, fixes imports
Comments suppressed due to low confidence (1)

__functions/upload-image.js:12

  • S3 client is initialized but never used. This should be removed as upload functionality now uses Netlify Blobs via the storage module.
const s3 = new AWS.S3({
  accessKeyId: process.env.MY_AWS_ACCESS_KEY_ID,
  secretAccessKey: process.env.MY_AWS_SECRET_ACCESS_KEY,
});

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread netlify-json/fetch.sh Outdated
Comment thread package.json Outdated
Comment thread __functions/url-summary.js Outdated
Comment thread __functions/url-summary.js
Comment thread __functions/upload-image.js Outdated
Comment thread __functions/storage.js
Comment thread __functions/list-notes.js Outdated
Comment thread __functions/cv-ai.js Outdated
Comment thread __functions/add-link.js Outdated
Comment thread __functions/add-link.js Outdated
simonmcmanus and others added 3 commits January 3, 2026 12:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI commented Jan 3, 2026

Copy link
Copy Markdown

@simonmcmanus I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI commented Jan 3, 2026

Copy link
Copy Markdown

@simonmcmanus I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you.

simonmcmanus and others added 8 commits January 3, 2026 12:32
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@simonmcmanus
simonmcmanus merged commit e7d5579 into main Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants