Skip to content

Run test matrix on macOS/Windows and normalize readonly fixture newlines#8

Merged
simonw merged 3 commits into
mainfrom
copilot/test-workflow-matrix-macos-windows
Jun 6, 2026
Merged

Run test matrix on macOS/Windows and normalize readonly fixture newlines#8
simonw merged 3 commits into
mainfrom
copilot/test-workflow-matrix-macos-windows

Conversation

Copilot AI commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This updates the test workflow to run across Linux, macOS, and Windows, which exposed newline-sensitive assertions in readonly-directory tests. The test fixtures now write LF line endings explicitly so the same assertions hold across platforms.

  • Workflow

    • Add an OS matrix to the Test workflow:
      • ubuntu-latest
      • macos-latest
      • windows-latest
    • Keep the existing Python version matrix unchanged.
  • Test fixture normalization

    • Update readonly-directory test fixtures to write files with explicit \n newlines.
    • This removes Windows-only \r\n output differences when guest code reads host-provided files.
  • Affected tests

    • tests/test_replay_session.py
    • tests/test_runtime_semantics.py
(tmp_path / "hello.txt").write_text("hello from wasi\n", newline="\n")

Copilot AI changed the title Extend test matrix to macOS and Windows Stabilize readonly-directory replay test across Windows line endings Jun 6, 2026
Copilot finished work on behalf of simonw June 6, 2026 18:03
Copilot AI requested a review from simonw June 6, 2026 18:03
Copilot AI changed the title Stabilize readonly-directory replay test across Windows line endings Run test matrix on macOS/Windows and normalize readonly fixture newlines Jun 6, 2026
Copilot finished work on behalf of simonw June 6, 2026 18:33
@simonw simonw marked this pull request as ready for review June 6, 2026 18:46
@simonw simonw merged commit 5e79a4f into main Jun 6, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants