Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlite_utils/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,7 @@ def rows_where(
:param offset: Integer for SQL offset
"""
if not self.exists():
return
raise NoTable(f"Table {self.name} does not exist")
sql = f"select {select} from {quote_identifier(self.name)}"
if where is not None:
sql += " where " + where
Expand Down Expand Up @@ -4105,7 +4105,7 @@ def delete_where(
:param analyze: Set to ``True`` to run ``ANALYZE`` after the rows have been deleted.
"""
if not self.exists():
return self
raise NoTable(f"Table {self.name} does not exist")
sql = f"delete from {quote_identifier(self.name)}"
if where is not None:
sql += " where " + where
Expand Down
7 changes: 7 additions & 0 deletions tests/test_delete.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import pytest
import sqlite_utils
from sqlite_utils.db import NoTable


def test_delete_rowid_table(fresh_db):
Expand Down Expand Up @@ -62,3 +64,8 @@ def test_delete_where_analyze(fresh_db):
assert list(fresh_db.table("sqlite_stat1").rows) == [
{"tbl": "table", "idx": "idx_table_i", "stat": "6 1"}
]


def test_delete_where_nonexistent_table(fresh_db):
with pytest.raises(NoTable):
fresh_db.table("does_not_exist").delete_where()
6 changes: 6 additions & 0 deletions tests/test_rows.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,9 @@ def test_pks_and_rows_where_compound_pk_declaration_order(fresh_db):
fresh_db.table("t").insert({"a": "A", "b": "B"})
pks_and_rows = list(fresh_db.table("t").pks_and_rows_where())
assert pks_and_rows == [(("A", "B"), {"b": "B", "a": "A"})]


def test_rows_where_nonexistent_table_raises(fresh_db):
from sqlite_utils.db import NoTable
with pytest.raises(NoTable):
list(fresh_db.table("does_not_exist").rows_where())
Loading