Closed
Conversation
Contributor
Author
|
No idea why tests are failing on FF, works fine locally |
Contributor
Author
|
Closing in favour of simplajs/simpla#86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts to a mixin for v1 Web Components.
Usage
Major Changes
simplaConfigproperty rather than a factory functionupdateFromSimplaandupdateSimplaBuffermethods rather than declaringsetCallback/getCallbackmethods in the config, if they want to override the set / get behaviour e.g.Don't care about the names, they were just the private names implemented in the old behavior
Also tweaks how readonly / editable interact with one another, essentally the same behaviour I believe, but a little bit more robust