Add support for oneshot_lines coverage mode#1154
Open
fatkodima wants to merge 1 commit intosimplecov-ruby:mainfrom
Open
Add support for oneshot_lines coverage mode#1154fatkodima wants to merge 1 commit intosimplecov-ruby:mainfrom
oneshot_lines coverage mode#1154fatkodima wants to merge 1 commit intosimplecov-ruby:mainfrom
Conversation
fatkodima
commented
Feb 7, 2026
| def process_coverage_result | ||
| adapt_coverage_result | ||
| remove_useless_results | ||
| adapt_coverage_result |
Contributor
Author
There was a problem hiding this comment.
In this PR, Coverage.stub_line is used, which is a pretty costly method. So I swapped lines here to filter unneeded files first before doing the actual work.
Collaborator
|
Looking good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #710.
https://bugs.ruby-lang.org/issues/15022
We use coverage on CI and I noticed that it significantly slows down the tests. After experimenting with
oneshot_linescoverage mode, the runtime dropped a lot (it was 15 minutes before and now is 10 minutes).