Open
Conversation
4 tasks
sferik
force-pushed
the
json-formatter-metrics
branch
from
8398641 to
35f35b5
Compare
sferik
force-pushed
the
json-formatter-metrics
branch
from
35f35b5 to
30e31e9
Compare
Enhance the JSON coverage output with per-file coverage percentages, a
total section with aggregate statistics, full group stats, and method
coverage support.
Per-file output now includes covered_percent (always), and when enabled:
branches_covered_percent and methods array with methods_covered_percent.
The total and groups sections report full statistics (covered, missed,
total, percent, strength) for each enabled coverage type (line, branch,
method).
Breaking change: group stats change from { covered_percent: 80.0 } to
the full stats shape with the key renamed to percent.
Based on the ideas in codeclimate-community/simplecov_json_formatter#12.
Co-Authored-By: Tejas <tejas.shetty@mailbox.org>
sferik
force-pushed
the
json-formatter-metrics
branch
from
30e31e9 to
8931869
Compare
sferik
force-pushed
the
json-formatter-metrics
branch
from
d8be1a3 to
94db9fa
Compare
Report all four types of coverage threshold violations in the JSON formatter's errors object: minimum_coverage, minimum_coverage_by_file, minimum_coverage_by_group, and maximum_coverage_drop. Each violation includes expected and actual values. This makes the JSON self-contained for downstream consumers (e.g. CI reporters) that don't have access to the Ruby process. Co-Authored-By: Tejas <tejas.shetty@mailbox.org>
sferik
force-pushed
the
json-formatter-metrics
branch
from
94db9fa to
3ea2cf7
Compare
Contributor
|
@sferik I did a very quick review of this and one thing caught my eye... It appears as though the statistics summaries are constructed such that, definitionally, In our data, we track a third state which is "omit", which is for blank lines and comments -- lines that cannot be covered. We then define coverage as This is a major difference and I'm guessing this definition is not new to SimpleCov in this PR, so this is just an FYI of something that I thought I'd mention as you are on a 1.0 push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the JSON coverage output with per-file coverage percentages, a total section with aggregate statistics, full group stats, and method coverage support.
Per-file output now includes covered_percent (always), and when enabled: branches_covered_percent and methods array with
methods_covered_percent. The total and groups sections report full statistics (covered, missed, total, percent, strength) for each enabled coverage type (line, branch, method).Breaking change: group stats change from
{ covered_percent: 80.0 }to the full stats shape with the key renamed topercent.Based on the ideas in codeclimate-community/simplecov_json_formatter#12.