Update e2e backup tests for backup-rework CLI changes - #1255
Open
RaunakJalan wants to merge 9 commits into
Open
Conversation
RaunakJalan
commented
Aug 19, 2026
RaunakJalan
commented
Collaborator
- backup import: positional arg → --from-file flag (3 locations)
- backup restore: remove --cluster-id flag (no longer exists)
- backup import: positional arg → --from-file flag (3 locations) - backup restore: remove --cluster-id flag (no longer exists)
The LVol model uses `crypto_bdev` (a device name string like
"crypto_LVOL_60"), not `crypto` (boolean). The assertion was always
failing because `d.get("crypto")` returned None.
max-subsys moved to cluster-level; sn configure no longer accepts it.
RaunakJalan
force-pushed
the
fix/backup-rework-e2e
branch
from
August 21, 2026 09:19
2c7c2b4 to
8ae760a
Compare
…EM to 50 Adjust for 12k max-subsys limit: 60 subsystems x 50 ns/subsystem = 3000 lvols + 9000 snaps = 12000 entities. Both Docker and K8s variants.
RaunakJalan
force-pushed
the
fix/backup-rework-e2e
branch
from
August 21, 2026 10:00
a04c217 to
415e9e1
Compare
Docker workflows: fix --max-lvol → --max-subsys in bootstrap calls. K8s native workflows: move maxSubsystemCount and vcpuCount to StorageCluster spec, replace partitions with enableJournalDevice in StorageNodeSet spec, remove corePercentage (replaced by vcpuCount calculated from CPU count * percentage), rename max_lvol input to max_subsys across all workflows.
…eCluster CRDs These fields were removed from the operator CRD in PR #440. Setting them causes strict decoding errors on latest operator.
hugepages_mem is now a required field in cluster create API. Default to 15G for all K8s native pipelines.
RaunakJalan
force-pushed
the
fix/backup-rework-e2e
branch
from
August 21, 2026 13:10
b3f2356 to
635c358
Compare
…cleanup timeouts Three changes to prevent the test from running 16+ hours when the cluster is broken (see run 32497309385): 1. _phase_rapid_restart_cycles: require >70% of iterations to detect node going offline, otherwise raise RuntimeError immediately. Previously all 30 iterations could silently time out as no-ops. 2. _wait_lvols_deleted: reduce stall_timeout from 1800 to 600s. The old value equalled the overall timeout so the stall check never fired independently. 3. _phase_cleanup: reduce CLEANUP_TIMEOUT from 1800 to 600s and pass stall_timeout=120s to delete_all_clones/delete_all_lvols. When the cluster is SUSPENDED/in_activation, cleanup now gives up after 2 min of no progress per step instead of 30 min. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The NFS base directory is created with sudo (root-owned), so the subsequent mkdir for the timestamped subdirectory also needs sudo. Add chown after mkdir so the cp that follows works without sudo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.