Skip to content

batch migration checksum issue workaround - #1256

Open
EbiRider wants to merge 45 commits into
mainfrom
batch-lvol-test
Open

batch migration checksum issue workaround#1256
EbiRider wants to merge 45 commits into
mainfrom
batch-lvol-test

Conversation

@EbiRider

Copy link
Copy Markdown
Collaborator

issues fixed in this PR:

  • data corruption: on stress cases if a batch lvol migration is performed on a group that is connected to multiple clients, corruption can happen this workaround implemented by making the source listeners inaccessible
  • incorrect chain build on complex trees, where the calls are skipped by confusing the snapshots actually present or those created by the lvol migration operation
  • ns id passed explicitly on the target ensuring consistent ns ids between the source and target

@EbiRider

Copy link
Copy Markdown
Collaborator Author

a new issue regarding hublvol being detached on retry path
this is a left out refactor from an earlier PR for hublvol manager as per that PR the hublvol is to remain attached across lvol migrations and is only detched after a 20 minutes idle time where the hublvol is left open and idle
we will remove any call sight that requests hublvol detach from the batch migration as it is entirely handled by the hublvol manager which is a singleton module used for both batch lvol migration and lvol migration

@EbiRider

Copy link
Copy Markdown
Collaborator Author

one suspect to the issue we have with checksum zero is the final migration taking so long one potential cause is high delta on some of the lvols migrated on the final step
before on batch migration we always had one intermediate, now however this change will cause the workers to check for delta size and if it's higher than the assigned threshold in constants it will signal the master thread which in turn will make all workers take an extra round of intermediates this can happen up to the max intermediates assigned on the constants file

this should ensure that the final delta is minimum and a faster final step execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant