Adapt configuration to metrics v2 - #421
Draft
mxsrc wants to merge 1 commit into
Draft
Conversation
The metrics are introduced to API v2, and allow to use more narrow service-account-based authentication.
Member
|
just wanted to double check: is the dashboard: controlplane_dashboards.yaml deployed on live cluster and verified? |
Contributor
Author
|
No, I don't have a cluster at the moment I'm afraid. We can wait until one is available. |
Collaborator
|
Woah 😳 Does this need to go into 26.3 or is it enough for afterwards? |
Contributor
Author
|
This is indeed not needed for 26.3. It was originally intended for that, but on sbcli side we just introduced the metrics to API v2, so we will convert all consumers of metrics to it during the next release, this is part of that. I was trying to rush things I suppose. I adapted the roadmap and converted to a draft for now, sorry for the confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics are introduced to API v2, and allow to use more narrow service-account-based authentication. This depends on simplyblock/sbcli#1236.