fix(backuprestore): use pool UUID instead of pool name in restored PV's volume handle - #447
Open
boddumanohar wants to merge 1 commit into
Open
fix(backuprestore): use pool UUID instead of pool name in restored PV's volume handle#447boddumanohar wants to merge 1 commit into
boddumanohar wants to merge 1 commit into
Conversation
…'s volume handle ensurePV built the CSI VolumeHandle as clusterUUID:PoolName:lvolID, while every other consumer (volumemigration_controller, persistentvolumeclaim_controller) and every dynamically-provisioned PV parse the middle segment as an immutable pool UUID. A pool rename would silently break lookups keyed off a restored volume's handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensurePVin theBackupRestorecontroller built the CSIVolumeHandleasclusterUUID:PoolName:lvolID. Every other consumer of this handle format (volumemigration_controller.go,persistentvolumeclaim_controller.go) — and every dynamically-provisioned PV — treats the middle segment as an immutable pool UUID, not the mutable pool name.ensurePVto userestoreCR.Status.PoolUUIDinstead ofrestoreCR.Status.PoolName.Test plan
go build ./...go test ./internal/controller/...(full suite passes)TestBackupRestoreEnsurePVIncludesCSIAttributesto assert the newcluster-uuid:pool-uuid:lvol-uuidhandle format🤖 Generated with Claude Code