fix(max-tokens): anthropic models streaming vs non-streaming#2999
Merged
icecrasher321 merged 3 commits intostagingfrom Jan 27, 2026
Merged
fix(max-tokens): anthropic models streaming vs non-streaming#2999icecrasher321 merged 3 commits intostagingfrom
icecrasher321 merged 3 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryThis PR implements differentiated token limits for Anthropic models based on whether requests are streaming or non-streaming, addressing timeout issues with non-streaming requests. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Agent
participant Provider as Anthropic/Bedrock Provider
participant Models as models.ts
participant API as Anthropic/Bedrock API
User->>Agent: Configure agent with model & maxTokens
Agent->>Provider: executeRequest(model, stream, maxTokens)
alt maxTokens provided by user
Provider->>Provider: Use Number.parseInt(request.maxTokens)
else maxTokens not provided
Provider->>Models: getMaxOutputTokensForModel(model, stream)
alt Streaming request
Models-->>Provider: Return maxOutputTokens.max (e.g., 64000)
else Non-streaming request
Models-->>Provider: Return maxOutputTokens.default (e.g., 4096)
end
end
Provider->>API: API call with determined max_tokens
API-->>Provider: Response (within token limit)
Provider-->>Agent: ProviderResponse
Agent-->>User: Generated content
|
Collaborator
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anthropic models streaming vs non-streaming token limits.
Type of Change
Testing
Tested manually with @Sg312
Checklist