feat(logs): add copy link and deep-link support for log entries#3863
feat(logs): add copy link and deep-link support for log entries#3863waleedlatif1 merged 3 commits intostagingfrom
Conversation
Switch buildLogUrl from ?search= to ?executionId= so email and Slack 'View Log' buttons open the logs page with the specific execution auto-selected and the details panel expanded.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Written by Cursor Bugbot for commit aa4f229. Configure here. |
Greptile SummaryThis PR completes the "deep-link" log feature by updating the workspace notification delivery service to generate Key changes:
Confidence Score: 5/5Safe to merge — single-line change with no logic risk and a well-tested front-end counterpart already in staging. The effective diff is one line: renaming the URL query parameter from No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant TriggerDev as Trigger.dev Task
participant Delivery as workspace-notification-delivery.ts
participant Email as Email / Slack
participant User as User (clicks link)
participant LogsPage as /logs page (logs.tsx)
TriggerDev->>Delivery: executeNotificationDelivery(params)
Delivery->>Delivery: buildLogUrl(workspaceId, executionId)<br/>→ ?executionId=<id>
Delivery->>Email: send email/Slack with logUrl
User->>LogsPage: GET /workspace/:id/logs?executionId=<id>
LogsPage->>LogsPage: read ?executionId param<br/>pendingExecutionIdRef = id
LogsPage->>LogsPage: initializeFromURL() → enable logsQuery
loop pagination until found
LogsPage->>LogsPage: search sortedLogs for executionId
alt found
LogsPage->>LogsPage: dispatch TOGGLE_LOG → open sidebar
else not found, hasNextPage
LogsPage->>LogsPage: fetchNextPage()
else exhausted
LogsPage->>LogsPage: clear pendingExecutionIdRef
end
end
Reviews (1): Last reviewed commit: "feat(notifications): use executionId dee..." | Re-trigger Greptile |
Summary
?executionId=that deep-links directly to the specific log?search=with?executionId=in notification delivery URLs (email + Slack "View Log" buttons) so they open the log directlyuseEffectref-sync effects by assigning refs inline during renderisFetchingref in deps, and callingfetchNextPagebefore query succeedsType of Change
Testing
Tested manually
Checklist