Skip to content

fix(desktop-browser): keep error-page focus recovery inside the browser and route hard reload through recovery - #8442

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/browser-release-review-followups
Sep 30, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/browser-release-review-followups

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Error pages only take focus for keyboard recovery when nothing in Sim holds focus (as when it was in the native page that failed); any focused element — the chat composer, its send button, the omnibox mid-edit, toolbar buttons — keeps it. Previously only text fields outside the page were protected
  • Hard reload (Cmd/Ctrl+Shift+R, Force Reload) on a failed or hung page now takes plain reload's recovery: a load error retries the URL that failed (which can differ from the committed page, e.g. after a timed-out deferred restore), and a hung renderer is restarted instead of reloaded in place; normal and crashed pages still reload past the cache
  • The omnibox and find bar also ignore keyCode === 229 during IME composition, matching the workspace find bar and rich editor

Type of Change

  • Bug fix

Testing

  • vitest desktop (875) and sim browser suites (196), type-check both apps, bun run lint, check-block-registry, bun run check:audits, docs-manifest:check
  • Verified in real Electron that a load error commits Chromium's error page at the failed URL, so hard reload on a load error already retried the right address; the recovery routing matters for hung pages, where it reuses reloadPage's existing restart

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 30, 2026 1:11am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adjusts browser error recovery and keyboard input handling.

The PR appears safe to merge; no outstanding finding or new actionable issue was identified.

Summary

The PR keeps focus on existing Sim controls when a browser error page appears and routes hard reload through recovery for failed or hung pages. It also adds IME key handling to the omnibox and browser find bar.

  • The latest change makes hard reload retry the recorded failed URL, including when it differs from the committed URL.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  HardReload[Hard reload] --> Issue{Page issue}
  Issue -->|Load error| FailedURL[Retry recorded failed URL]
  Issue -->|Unresponsive| Restart[Restart hung renderer]
  Issue -->|Other or none| Bypass[Reload ignoring HTTP cache]
Loading

Reviews (3) · Last reviewed commit: "fix(desktop-browser): retry the failed U..."

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated
Comment thread apps/desktop/src/main/browser-agent/session.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

…s focus, and keep cache bypass except for hung pages
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/desktop/src/main/browser-agent/session.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 3ab3459 into staging Sep 30, 2026
25 of 27 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/browser-release-review-followups branch September 30, 2026 01:19

This branch was previously deployed

1 inactive deployment
Preview — 8d079918 Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant