Skip to content

fix(integrations): complete account connections in place - #8493

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/integrations-connect-lifecycle
Oct 1, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/integrations-connect-lifecycle

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep account connection and reconnect on the originating Integrations page, with automatic refresh and a same-tab fallback when popups are unavailable.
  • Complete managed MCP authorization directly while preserving invitation submission and existing Search flows.
  • Correlate browser and desktop completion per attempt, prevent overlapping starts, and preserve the selected OAuth credential during reconnect.

Type of Change

  • Bug fix

Testing

  • 197 focused and neighboring tests; five new callback/state regressions demonstrated failing before the fix.
  • Browser/Electron E2E: 13 lifecycle checks covering completion, cancellation, reconnect, preserved page state, popup fallback, separate sessions, and invitation compatibility. JSON report and screenshot generated; CI uploads failure artifacts.
  • App and desktop type checks, lint, 52 audits, block registry validation, and docs manifest check.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 12:48am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds account connection completion flow for integrations.

The PR appears safe to merge; no outstanding findings remain.

Summary

The PR completes managed account authorization through the originating Integrations page, using correlated popup or desktop handoffs and a same-tab fallback. Since the previous review, it adds a shared guard against overlapping connection attempts and extends the desktop fixture to exercise MCP accounts.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Integrations Connect or Reconnect] --> B[Start correlated authorization]
  B --> C{Desktop or web?}
  C -->|Desktop| D[Native browser handoff]
  C -->|Web popup| E[Provider popup]
  C -->|Popup unavailable| F[Same-tab authorization]
  D --> G[Completion page]
  E --> G
  F --> G
  G --> H[Refresh accounts or return to Integrations]
Loading

Reviews (2) · Last reviewed commit: "fix(integrations): preserve active accou..."

Comment thread apps/sim/hooks/queries/organization-accounts.ts
Comment thread apps/sim/lib/credential-groups/oauth-popup.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 26 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/scripts/fixtures/desktop-source-connect.tsx Outdated
Comment thread apps/sim/scripts/fixtures/desktop-source-connect.tsx Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 517a5f3 into staging Oct 1, 2026
27 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/integrations-connect-lifecycle branch October 1, 2026 00:53

This branch was previously deployed

1 inactive deployment
Preview — 7e18c946 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant