Skip to content

improvement(guidance): make every ratchet shrink-only, scope rules to their files, fix stale guidance - #8594

Merged
waleedlatif1 merged 3 commits into
stagingfrom
improvement/agent-surface-followups
Oct 3, 2026
Merged

improvement(guidance): make every ratchet shrink-only, scope rules to their files, fix stale guidance#8594
waleedlatif1 merged 3 commits into
stagingfrom
improvement/agent-surface-followups

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • check:test-patterns --update wrote the current violation set unchecked, so following its own failure message admitted new debt. It is now shrink-only like the other ratchets, and a missing baseline fails closed instead of crashing.
  • check:react-query carried an empty baseline whose --update-baseline could raise it. Every violation already failed, so the baseline, its update flag, and the strict/ratchet split are removed; behavior is unchanged.
  • check:utils: drop the packages/testing/src/factories/id.ts allowlist entry by rewording the TSDoc line that tripped it.
  • Rule scoping: constitution.md (marketing copy) and sim-react-performance.md loaded in every session; sim-url-state.md (22 KB) loaded for every API route edit. Each now loads only for the files it governs.
  • Guidance fixes: a boolean toggle stays Switch (ChipSwitch is a segmented choice), current chip names in sim-styling.md, SettingsField usage, the @sim/utils/random helpers check:utils already requires, db-migrate now covers the schema mock and drizzle sync, check:migrations base-ref wording, and a common-task → skill index in apps/sim/AGENTS.md.

Type of Change

  • Improvement

Testing

  • Probed: check:test-patterns --update refuses a new local helper and writes nothing; a missing baseline fails with a restore message
  • bun run lint, bun run type-check, bun run check:audits (58), docs-manifest:check, block-registry check, root bun run test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@waleedlatif1
improvement(guidance): make every ratchet shrink-only, scope rules to…
6558eae 
… their files, fix stale guidance

- check:test-patterns --update refuses new violations and fails closed on a missing baseline
- check:react-query drops its unused, growable baseline: every violation fails, as it already did
- check:utils drops the id.ts allowlist entry by rewording the comment that tripped it
- constitution, react-performance, and url-state rules load only for the files they govern
- guidance: Switch stays the boolean toggle, current chip names, @sim/utils/random, db-migrate covers the schema mock and drizzle sync, apps/sim/AGENTS.md maps common tasks to skills
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 3, 2026 07:50
@vercel

vercel Bot commented Oct 3, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 3, 2026 8:20am UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 3, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 24 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .claude/rules/constitution.md
Comment thread .cursor/rules/sim-settings-pages.mdc Outdated
Comment thread .agents/skills/db-migrate/SKILL.md Outdated
Comment thread .claude/rules/sim-react-performance.md Outdated
@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Updates guidance docs and linting rules.

The PR appears safe to merge; no outstanding finding or new actionable failure was identified.

Summary

The PR makes the test-pattern baseline update shrink-only, removes the unused React Query baseline, and corrects and scopes repository guidance.

  • The latest revision adjusts URL-state rule paths so app hooks and navigation helpers remain covered without restoring app-wide .ts coverage.
  • Both previous review threads are resolved: the navigation-helper path remains covered, and the testing comment was withdrawn.

Reviews (3) · Last reviewed commit: "chore(guidance): scope url-state by dire..."

greptile-apps[bot]
greptile-apps Bot reviewed Oct 3, 2026
View reviewed changes
Comment thread .claude/rules/sim-url-state.md Outdated
Comment thread scripts/check-test-patterns.ts
@waleedlatif1

waleedlatif1 commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 3, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 24 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .claude/rules/sim-url-state.md Outdated
@waleedlatif1

waleedlatif1 commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 3, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 35adcf7 into staging Oct 3, 2026
41 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/agent-surface-followups branch October 3, 2026 08:29
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 3, 2026
Open

This branch was successfully deployed

1 active deployment
Preview — 6644d806 Deployed Oct 3, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1