Skip to content

chore(table): remove unused table-update background task - #8708

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-table-update-task
Oct 7, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-table-update-task

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the table-update Trigger.dev task and its runner (lib/table/update-runner.ts) — nothing has dispatched it since the Copilot bulk-rows use case that triggered it was deleted in chore(cleanup): apply codebase-design deep-module pass across the monorepo #8549; bulk updates by filter run inline via updateRowsByFilter
  • Remove updatePageByIds / PagePatch from lib/table/rows/ordering.ts (only the runner used them), the runner's unit test, and the integration block that exercised the background path
  • Drop stale comments that pointed at the runner
  • TableJobType keeps 'update' so historic table_jobs rows still parse; no schema change

Type of Change

  • Chore

Testing

  • Confirmed no static or dynamically built table-update dispatch and no remaining creator of update table jobs
  • bun run lint, bun run type-check, bun run check:audits, bun run docs-manifest:check, block-registry check — green
  • Root bun run test: all green except 3 unrelated heavy tests that timed out under machine load; each passes when re-run on its own

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 7, 2026 12:34am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Removes a background task for applying bulk table updates.

This PR appears safe to merge.

What we checked:

  • Bulk updates still run: The current application call runs updateRowsByFilter directly and does not need the deleted worker.
  • Old jobs remain readable: TableJobType still includes 'update'. The cleanup job marks stale running jobs failed without filtering by type.

Summary

Removes the unused table-update task, its runner, the runner-only write helper, and their tests.

  • Current bulk updates still run through updateRowsByFilter.
  • TableJobType retains 'update' for historical jobs.
  • No actionable issues found.

Reviews (1) · Last reviewed commit: "chore(table): remove unused table-update..."

@waleedlatif1
waleedlatif1 merged commit 5ee756f into staging Oct 7, 2026
23 of 24 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/remove-table-update-task branch October 7, 2026 00:45

This branch was previously deployed

1 inactive deployment
Preview — 75d92433 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant