Skip to content

chore(google-ads): remove synthetic E2E suite - #8857

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/remove-google-ads-e2e
Oct 9, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/remove-google-ads-e2e

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the synthetic Google Ads E2E script and its invocation from the HTTP E2E runner.
  • The script bypasses the app and executor and supplies its own Google responses, so it cannot establish live API compatibility. This removes its isolated parser and validation checks; production integration behavior is unchanged.

Type of Change

  • Chore

Testing

Root bun run test, bun run lint, bun run type-check, all 58 check:audits, docs-manifest check, block-registry check, pinned actionlint, shell syntax check, and git diff --check.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests updated and passing (removed the synthetic suite)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 5:46pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Removes the synthetic Google Ads suite and its invocation from the HTTP E2E runner.

  • The CLI E2E group no longer runs the synthetic Google Ads suite.

Reviews (1) · Last reviewed commit: "chore(google-ads): remove synthetic E2E ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 1897cbb into staging Oct 9, 2026
36 of 37 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/remove-google-ads-e2e branch October 9, 2026 17:44

This branch was successfully deployed

1 active deployment
Preview — 53460adf Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant